Skip to content

🎨 [Frontend] Second app on Sim4Life.lite (II) #7823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 5, 2025
Merged

🎨 [Frontend] Second app on Sim4Life.lite (II) #7823

merged 20 commits into from
Jun 5, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 5, 2025 •
edited
Loading

What do these changes do?

Same as #7807, but this time the Avatar.js (Bonus) works for all cases

Fixed:
fixed

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz marked this pull request as ready for review June 5, 2025 08:19
@odeimaiz odeimaiz requested a review from Copilot June 5, 2025 08:19
@odeimaiz odeimaiz self-assigned this Jun 5, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jun 5, 2025
@odeimaiz odeimaiz added this to the Bazinga! milestone Jun 5, 2025
@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 5, 2025
Copilot AI reviewed Jun 5, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the frontend to support a second app (“Sim4Life.framework”) in the lite version and refines user avatar and comment handling, plus updates editor subtitles to link to docs.

  • Adds a new service entry for Sim4Life.framework in UI config
  • Refactors Avatar.emailToThumbnail into a single function signature
  • Caches failed user fetches and improves comment UI fallback
  • Switches subtitle labels to LinkLabel and adds doc URLs in editors

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
services/static-webserver/client/source/resource/osparc/ui_config.json Added Sim4Life.framework button entry
services/static-webserver/client/source/class/osparc/utils/Avatar.js Merged getUrl into emailToThumbnail signature
services/static-webserver/client/source/class/osparc/store/Users.js Introduced __unknowns list to skip repeated fetches
services/static-webserver/client/source/class/osparc/info/CommentUI.js Improved default avatar/username fallback handling
services/static-webserver/client/source/class/osparc/editor/TextEditor.js Changed subtitle to LinkLabel and simplified layout
services/static-webserver/client/source/class/osparc/editor/MarkdownEditor.js Added external Markdown docs URL to subtitle
services/static-webserver/client/source/class/osparc/editor/HtmlEditor.js Added external HTML docs URL to subtitle
Comments suppressed due to low confidence (1)

services/static-webserver/client/source/class/osparc/info/CommentUI.js:115

  • [nitpick] You removed the initial placeholder avatar and username. It’s better to set a default thumbnail and label immediately (before async resolution) to avoid blank UI while the fetch is pending.
const thumbnail = this.getChildControl("thumbnail");

@odeimaiz
Copy link
Member Author

odeimaiz commented Jun 5, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-neutral = deploy to dockerhub
        • check-skipped = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests

@odeimaiz odeimaiz removed the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 5, 2025
GitHK
GitHK reviewed Jun 5, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz added 🤖-automerge marks PR as ready to be merged for Mergify release Preparation for pre-release/release labels Jun 5, 2025
@odeimaiz odeimaiz requested a review from giancarloromeo June 5, 2025 11:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz removed the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 5, 2025
@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #7823 has been dequeued. The pull request rule doesn't match anymore.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@odeimaiz odeimaiz merged commit 0e41132 into ITISFoundation:master Jun 5, 2025
58 of 59 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
Closed
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK left review comments

Copilot code review Copilot Copilot left review comments

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) release Preparation for pre-release/release t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

Bazinga!

Development

Successfully merging this pull request may close these issues.

4 participants

@odeimaiz @GitHK @pcrespov @matusdrobuliak66